vicennial commented on code in PR #41789:
URL: https://github.com/apache/spark/pull/41789#discussion_r1247634835
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1519,7 +1508,7 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
command = fun.getCommand.toByteArray,
// Empty environment variables
envVars = Maps.newHashMap(),
- pythonIncludes = pythonIncludes,
+ pythonIncludes =
sessionHolder.artifactManager.getSparkConnectPythonIncludes.asJava,
Review Comment:
@HyukjinKwon With directly fetching the Python Includes, I've removed the
`private lazy val pythonIncludes` and
`SessionHolder#withSessionBasedPythonPaths` since we don't need to propagate
them via confs anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
