cxzl25 commented on code in PR #40972:
URL: https://github.com/apache/spark/pull/40972#discussion_r1250108906
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java:
##########
@@ -188,6 +212,31 @@ public void onFailure(Throwable t) {
}
}
+ private <T> void retry(
+ int times,
+ final int maxRetries,
+ int delayMs,
+ Supplier<CompletableFuture<T>> action,
+ CompletableFuture<T> future) {
+ action.get()
+ .thenAccept(future::complete)
+ .exceptionally(e -> {
+ boolean isIOException = e instanceof IOException
+ || (e.getCause() != null && e.getCause() instanceof
IOException);
Review Comment:
Indeed, the retry logic of enable sasl retries is missing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
