HyukjinKwon commented on code in PR #41342:
URL: https://github.com/apache/spark/pull/41342#discussion_r1250437230
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -101,6 +101,40 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
}
// The root of the query plan is a relation and we apply the transformations
to it.
+ def transformRelationAsDataset(rel: proto.Relation): Dataset[Row] = {
Review Comment:
This doesn't look making the code a lot better ... it basically saves the
call of `Dataset.ofRows` in the individual transformation, which doesn't seem a
lot of worthwhile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
