juliuszsompolski commented on code in PR #41748:
URL: https://github.com/apache/spark/pull/41748#discussion_r1250462950
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/QueryPlanningTracker.scala:
##########
@@ -89,8 +90,32 @@ object QueryPlanningTracker {
}
}
+/**
+ * Callbacks after planning phase completion.
+ */
+trait QueryPlanningTrackerCallback {
Review Comment:
I think `private[spark]` could work for these added sql APIs, as they are
inteded to be used internally from Spark Connect, maybe later also from
Thriftserver.
And the whole QueryPlanningTracker would better fit in `sql-core` rather
than `catalyst` (as it e.g. measures also physical planning, which is not in
catalyst; and it would actually be convenient to pass QueryExecution to these
callbacks, but we can't in catalyst). But moving it would break the existing
uses of QueryPlanningTracker...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
