cloud-fan commented on code in PR #41835:
URL: https://github.com/apache/spark/pull/41835#discussion_r1251319070
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryErrorsBase.scala:
##########
@@ -92,10 +84,6 @@ private[sql] trait QueryErrorsBase {
quoteByDefault(text.toUpperCase(Locale.ROOT))
}
- def toSQLConf(conf: String): String = {
Review Comment:
it's a bit weird that we put this in `DataTypeErrorsBase`, shall we name it
`QuotingUtils`? And we can move methods to it, like `toSQLType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
