HyukjinKwon commented on code in PR #41829:
URL: https://github.com/apache/spark/pull/41829#discussion_r1251339132
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -21,8 +21,12 @@ import java.net.URI
import java.util.UUID
import java.util.concurrent.Executor
+import scala.annotation.tailrec
+import scala.concurrent.duration.FiniteDuration
+import scala.util.{Failure, Success, Try}
+
import com.google.protobuf.ByteString
-import io.grpc.{CallCredentials, CallOptions, Channel, ChannelCredentials,
ClientCall, ClientInterceptor, CompositeChannelCredentials,
ForwardingClientCall, Grpc, InsecureChannelCredentials, ManagedChannel,
Metadata, MethodDescriptor, Status, TlsChannelCredentials}
+import io.grpc.{CallCredentials, CallOptions, Channel, ChannelCredentials,
ClientCall, ClientInterceptor, CompositeChannelCredentials,
ForwardingClientCall, Grpc, InsecureChannelCredentials, ManagedChannel,
Metadata, MethodDescriptor, Status, StatusRuntimeException,
TlsChannelCredentials}
Review Comment:
no biggie but optionally you can just wildcard import per
https://github.com/databricks/scala-style-guide#imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
