Github user meawoppl commented on a diff in the pull request:
https://github.com/apache/spark/pull/6336#discussion_r30908103
--- Diff: ec2/spark_ec2.py ---
@@ -750,7 +754,7 @@ def setup_cluster(conn, master_nodes, slave_nodes,
opts, deploy_ssh_key):
'mapreduce', 'spark-standalone', 'tachyon']
if opts.hadoop_major_version == "1":
- modules = filter(lambda x: x != "mapreduce", modules)
+ modules = list(filter(lambda x: x != "mapreduce", modules))
--- End diff --
Yep. I was also a bit confused why the list method .remove() isn't just
used here. But I opted for the safer thing which could potentially remove
multiple "mapreduce" entries. Should modules be a set()?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
