HyukjinKwon commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251824903


##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
     ],
 )
 

Review Comment:
   It makes sense to skip when there are few but I think we shouldn't just skip 
them like this if there are too many. 



##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
     ],
 )
 

Review Comment:
   We should fix instead of just skipping them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to