itholic commented on code in PR #39937:
URL: https://github.com/apache/spark/pull/39937#discussion_r1252528229
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala:
##########
@@ -32,56 +34,94 @@ class StrictDataTypeWriteCompatibilitySuite extends
DataTypeWriteCompatibilityBa
override def canCast: (DataType, DataType) => Boolean = Cast.canUpCast
test("Check struct types: unsafe casts are not allowed") {
- assertNumErrors(widerPoint2, point2, "t",
- "Should fail because types require unsafe casts", 2) { errs =>
-
- assert(errs(0).contains("'t.x'"), "Should include the nested field name
context")
- assert(errs(0).contains("Cannot safely cast"))
-
- assert(errs(1).contains("'t.y'"), "Should include the nested field name
context")
- assert(errs(1).contains("Cannot safely cast"))
- }
+ val errs = new mutable.ArrayBuffer[String]()
+ checkError(
+ exception = intercept[AnalysisException] (
+ DataType.canWrite("", widerPoint2, point2, true,
+ analysis.caseSensitiveResolution, "t", storeAssignmentPolicy, errMsg
=> errs += errMsg)
+ ),
+ errorClass = "INCOMPATIBLE_DATA_FOR_TABLE.CANNOT_SAFELY_CAST",
+ parameters = Map(
+ "tableName" -> "``",
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
