LuciferYang commented on code in PR #41814:
URL: https://github.com/apache/spark/pull/41814#discussion_r1252652729
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/application/ReplE2ESuite.scala:
##########
@@ -50,26 +51,29 @@ class ReplE2ESuite extends RemoteSparkSession with
BeforeAndAfterEach {
}
override def beforeAll(): Unit = {
- super.beforeAll()
- ammoniteOut = new ByteArrayOutputStream()
- testSuiteOut = new PipedOutputStream()
- // Connect the `testSuiteOut` and `ammoniteIn` pipes
- ammoniteIn = new PipedInputStream(testSuiteOut)
- errorStream = new ByteArrayOutputStream()
-
- val args = Array("--port", serverPort.toString)
- val task = new Runnable {
- override def run(): Unit = {
- ConnectRepl.doMain(
- args = args,
- semaphore = Some(semaphore),
- inputStream = ammoniteIn,
- outputStream = ammoniteOut,
- errorStream = errorStream)
+ // TODO(SPARK-44121) Remove this check condition
+ if (SystemUtils.isJavaVersionAtMost(JavaVersion.JAVA_17)) {
Review Comment:
All `RemoteSparkSession-based` test using Java 21 already skipped in
https://github.com/apache/spark/pull/41805, so we shouldn't initialize
`Ammonite ` here and connect to the remote spark connect server here.
This did not make local test fail, but the test on GA failed (Daily testing
of Java 21)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
