juliuszsompolski commented on PR #41527: URL: https://github.com/apache/spark/pull/41527#issuecomment-1621315457
@beliefer In what I've been working on: > Code Design I do plan to have SparkConnectStreamHandler be responsible for sending the RPCs. That's not yet ready in my PR, in the current iteration I had the execution thread send the RPCs, but I need to hand it over back to the SparkConnectStreamHandler thread. > Visibility I avoid the need for the refactoring by instead passing my own class implementing the `StreamObserver` interface that is just going to notify the "real" `StreamObserver` that there is something to be sent. This way I avoid the need for refactoring, and the StreamObserver is fine as an interface to be passed around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
