xinrong-meng commented on PR #39952: URL: https://github.com/apache/spark/pull/39952#issuecomment-1622600141
Thanks @EnricoMi ! I would suggest creating a separate `def wrap_..` for `PythonEvalType.SQL_MAP_ARROW_ITER_UDF` instead of introducing a new parameter `is_arrow_iter` to `wrap_batch_iter_udf`. That maintains logical consistency with the other `wrap_` functions (each function is dedicated to wrapping a specific type of UDF) and promotes a modular design. My point is subject to debate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
