Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6352#issuecomment-104721515
(Warning: drive-by comment; I'll look at this patch in more detail later)
One high-level comment:
For any patch which modifies scheduler internals, we should err on the side
of extremely liberal commenting of code, even if this means paragraph-long
comments. If it's tricky enough to merit a question in a GitHub code review,
then it deserves a comment. For instance, the `rdd.dependencies.size < 2`
check could benefit from a nearby comment that explains why this is safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
