grundprinzip commented on code in PR #41880:
URL: https://github.com/apache/spark/pull/41880#discussion_r1257233751
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -656,6 +654,16 @@ object SparkSession extends Logging {
this
}
+ /**
+ * Add an interceptor to be used during channel creation.
+ *
+ * Note that interceptors added last are executed first by gRPC.
Review Comment:
Please check in other parts of spark for proper doc strings. It needs as
well a since version marker.
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -20,13 +20,11 @@ import java.io.Closeable
import java.net.URI
import java.util.concurrent.TimeUnit._
import java.util.concurrent.atomic.AtomicLong
-
import scala.collection.JavaConverters._
import scala.reflect.runtime.universe.TypeTag
-
import com.google.common.cache.{CacheBuilder, CacheLoader}
+import io.grpc.ClientInterceptor
Review Comment:
I think there a bunch of Scala style issued Herr. Please use as well the
automatic reformat for the connect code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
