Github user meawoppl commented on a diff in the pull request:
https://github.com/apache/spark/pull/6336#discussion_r30918981
--- Diff: ec2/spark_ec2.py ---
@@ -750,7 +754,7 @@ def setup_cluster(conn, master_nodes, slave_nodes,
opts, deploy_ssh_key):
'mapreduce', 'spark-standalone', 'tachyon']
if opts.hadoop_major_version == "1":
- modules = filter(lambda x: x != "mapreduce", modules)
+ modules = list(filter(lambda x: x != "mapreduce", modules))
--- End diff --
I didn't know how all the machinery in this script worked, so I was
hesitant to make anything but minimal changes. I saw that there was a desire
to move it over to argparse?
I also have a major linguistic nit to pick with the asymmetry between
launch/destroy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
