Hisoka-X commented on code in PR #41347:
URL: https://github.com/apache/spark/pull/41347#discussion_r1259082276
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala:
##########
@@ -271,7 +271,10 @@ case class ScalarSubquery(
mayHaveCountBug: Option[Boolean] = None)
extends SubqueryExpression(plan, outerAttrs, exprId, joinCond, hint) with
Unevaluable {
override def dataType: DataType = {
- assert(plan.schema.fields.nonEmpty, "Scalar subquery should have only one
column")
+ if (!plan.schema.fields.nonEmpty) {
Review Comment:
make sure the `AnalysisException` will be throw, not `AssertionError`
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LeftSemiAntiJoinPushDownSuite.scala:
##########
@@ -437,25 +437,6 @@ class LeftSemiAntiJoinPushDownSuite extends PlanTest {
}
}
- Seq(LeftSemi, LeftAnti).foreach { case jt =>
Review Comment:
This test unnecessary. Because we can deduplicate those attributes in
anti-join / semi-join is a self-join. Please refer
https://github.com/apache/spark/pull/39131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
