Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/707#discussion_r12464716
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ShuffleMapTask.scala ---
@@ -58,15 +58,13 @@ private[spark] object ShuffleMapTask {
}
def deserializeInfo(stageId: Int, bytes: Array[Byte]): (RDD[_],
ShuffleDependency[_,_]) = {
- synchronized {
- val loader = Thread.currentThread.getContextClassLoader
- val in = new GZIPInputStream(new ByteArrayInputStream(bytes))
- val ser = SparkEnv.get.closureSerializer.newInstance()
- val objIn = ser.deserializeStream(in)
- val rdd = objIn.readObject().asInstanceOf[RDD[_]]
- val dep = objIn.readObject().asInstanceOf[ShuffleDependency[_,_]]
- (rdd, dep)
- }
+ val loader = Thread.currentThread.getContextClassLoader
--- End diff --
sure.
On Fri, May 9, 2014 at 10:58 AM, Patrick Wendell
<notificati...@github.com>wrote:
> In core/src/main/scala/org/apache/spark/scheduler/ShuffleMapTask.scala:
>
> > @@ -58,15 +58,13 @@ private[spark] object ShuffleMapTask {
> > }
> >
> > def deserializeInfo(stageId: Int, bytes: Array[Byte]): (RDD[_],
ShuffleDependency[_,_]) = {
> > - synchronized {
> > - val loader = Thread.currentThread.getContextClassLoader
> > - val in = new GZIPInputStream(new ByteArrayInputStream(bytes))
> > - val ser = SparkEnv.get.closureSerializer.newInstance()
> > - val objIn = ser.deserializeStream(in)
> > - val rdd = objIn.readObject().asInstanceOf[RDD[_]]
> > - val dep = objIn.readObject().asInstanceOf[ShuffleDependency[_,_]]
> > - (rdd, dep)
> > - }
> > + val loader = Thread.currentThread.getContextClassLoader
>
> I can just remove this code on merge - it's dead code
>
> â
> Reply to this email directly or view it on
GitHub<https://github.com/apache/spark/pull/707/files#r12464691>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
