aokolnychyi commented on code in PR #41962:
URL: https://github.com/apache/spark/pull/41962#discussion_r1261440669
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DeltaBasedUpdateAsDeleteAndInsertTableSuite.scala:
##########
@@ -17,44 +17,12 @@
package org.apache.spark.sql.connector
-import org.apache.spark.sql.{AnalysisException, Row}
-
-class DeltaBasedUpdateAsDeleteAndInsertTableSuite extends UpdateTableSuiteBase
{
+class DeltaBasedUpdateAsDeleteAndInsertTableSuite extends
DeltaBasedUpdateTableSuiteBase {
override protected lazy val extraTableProps: java.util.Map[String, String] =
{
val props = new java.util.HashMap[String, String]()
props.put("supports-deltas", "true")
props.put("split-updates", "true")
props
}
-
- test("nullable row ID attrs") {
Review Comment:
Moved these tests into `DeltaBasedUpdateTableSuiteBase` to reduce
duplication.
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DeltaBasedUpdateAsDeleteAndInsertTableSuite.scala:
##########
@@ -17,44 +17,12 @@
package org.apache.spark.sql.connector
-import org.apache.spark.sql.{AnalysisException, Row}
-
-class DeltaBasedUpdateAsDeleteAndInsertTableSuite extends UpdateTableSuiteBase
{
+class DeltaBasedUpdateAsDeleteAndInsertTableSuite extends
DeltaBasedUpdateTableSuiteBase {
override protected lazy val extraTableProps: java.util.Map[String, String] =
{
val props = new java.util.HashMap[String, String]()
props.put("supports-deltas", "true")
props.put("split-updates", "true")
props
}
-
- test("nullable row ID attrs") {
Review Comment:
Moved these tests into the newly added `DeltaBasedUpdateTableSuiteBase` to
reduce duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
