cloud-fan commented on code in PR #41725:
URL: https://github.com/apache/spark/pull/41725#discussion_r1262266076
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala:
##########
@@ -83,13 +83,17 @@ object DistributionAndOrderingUtils {
queryWithDistribution
}
- // Apply typeCoercionRules since the converted expression from
TransformExpression
- // implemented ImplicitCastInputTypes
- typeCoercionRules.foldLeft(queryWithDistributionAndOrdering)((plan,
rule) => rule(plan))
+ ResolveTimezoneAndCastExecutor.execute(queryWithDistributionAndOrdering)
case _ =>
query
}
+ private object ResolveTimezoneAndCastExecutor extends
RuleExecutor[LogicalPlan] {
Review Comment:
The name is a bit weird. How about just `TypeCoercionExecutor` as type
coercion is the main purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
