HyukjinKwon commented on code in PR #41924:
URL: https://github.com/apache/spark/pull/41924#discussion_r1262399738
##########
python/pyspark/testing/utils.py:
##########
@@ -291,7 +293,11 @@ def assertDataFrameEqual(df: DataFrame, expected:
DataFrame, check_row_order: bo
error_class="UNSUPPORTED_DATA_TYPE",
message_parameters={"data_type": type(df)},
)
- elif not isinstance(expected, DataFrame) and not isinstance(expected,
ConnectDataFrame):
+ elif (
+ not isinstance(expected, DataFrame)
+ and not isinstance(expected, ConnectDataFrame)
+ and not isinstance(expected, List)
Review Comment:
```suggestion
and not isinstance(expected, list)
```
List is for type hint.
##########
python/pyspark/testing/utils.py:
##########
@@ -291,7 +293,11 @@ def assertDataFrameEqual(df: DataFrame, expected:
DataFrame, check_row_order: bo
error_class="UNSUPPORTED_DATA_TYPE",
message_parameters={"data_type": type(df)},
)
- elif not isinstance(expected, DataFrame) and not isinstance(expected,
ConnectDataFrame):
+ elif (
+ not isinstance(expected, DataFrame)
+ and not isinstance(expected, ConnectDataFrame)
+ and not isinstance(expected, List)
Review Comment:
```suggestion
and not isinstance(expected, list)
```
List is for type hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
