learningchess2003 commented on code in PR #41864:
URL: https://github.com/apache/spark/pull/41864#discussion_r1262895833
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -935,9 +969,9 @@ object FunctionRegistry {
private def expressionGeneratorOuter[T <: Generator : ClassTag](name: String)
: (String, (ExpressionInfo, FunctionBuilder)) = {
- val (_, (info, generatorBuilder)) = expression[T](name)
+ val (_, (info, builder)) = expression[T](name)
Review Comment:
I felt it was because the name I created had the exact same name as the
variable above and I didn't want to cause confusion. Also, in other example
functions, builder is the variable name used for this kind of object, so I
thought it be good to clear up the ambigiuity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
