cloud-fan commented on code in PR #41949:
URL: https://github.com/apache/spark/pull/41949#discussion_r1263191119
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala:
##########
@@ -27,19 +27,28 @@ import
org.apache.spark.sql.catalyst.types.DataTypeUtils.toAttributes
import org.apache.spark.sql.execution.{CodegenSupport, LeafExecNode,
WholeStageCodegenExec}
import org.apache.spark.sql.execution.adaptive.{DisableAdaptiveExecutionSuite,
EnableAdaptiveExecutionSuite}
import org.apache.spark.sql.functions._
+import org.apache.spark.sql.internal.SQLConf.USE_PARTITION_EVALUATOR
import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.sql.test.SQLTestData.TestData
import org.apache.spark.sql.types.StructType
abstract class DebuggingSuiteBase extends SharedSparkSession {
Review Comment:
if all test cases need to run twice with partition evaluator on and off,
shall we just add a new `DebuggingSuiteWithPartitionEvaluator` with the config
enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
