juliuszsompolski commented on code in PR #41443:
URL: https://github.com/apache/spark/pull/41443#discussion_r1263874895
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -3314,4 +3336,12 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
session.catalog.listCatalogs().logicalPlan
}
}
+
+ private def userId(): String = {
+ sessionHolder.userId
+ }
+
+ private def sessionId(): String = {
+ sessionHolder.sessionId
+ }
Review Comment:
nit: there is already a def session = sessionHolder.session on top of the
file
add it there as one liners
```
private def userId = sessionHolder.userId
private def sessionId = sessionHolder.sessionId
```
by the way check it that `def session` needs to be public...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
