szehon-ho commented on code in PR #41990:
URL: https://github.com/apache/spark/pull/41990#discussion_r1264108300
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -241,3 +243,24 @@ case class BatchScanExec(
s"BatchScan ${table.name()}".trim
}
}
+
+case class StoragePartitionJoinParams(
+ keyGroupedPartitioning: Option[Seq[Expression]] = None,
+ commonPartitionValues: Option[Seq[(InternalRow, Int)]] = None,
+ applyPartialClustering: Boolean = false,
+ replicatePartitions: Boolean = false) {
+ override def equals(other: Any): Boolean = other match {
+ case other: StoragePartitionJoinParams =>
+ this.commonPartitionValues == other.commonPartitionValues &&
+ this.replicatePartitions == other.replicatePartitions &&
+ this.applyPartialClustering == other.applyPartialClustering
+ case _ =>
+ false
+ }
+
+ override def hashCode(): Int = Objects.hashCode(
+ commonPartitionValues: Option[Seq[(InternalRow, Int)]],
Review Comment:
Sorry i just remembered, this is due to a scala compiler problem:
```[error]
/Users/szehon/repos/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:263:5:
the result type of an implicit conversion must be more specific than Object
```
I think due to java method taking (Object...objects )
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -241,3 +243,24 @@ case class BatchScanExec(
s"BatchScan ${table.name()}".trim
}
}
+
+case class StoragePartitionJoinParams(
+ keyGroupedPartitioning: Option[Seq[Expression]] = None,
+ commonPartitionValues: Option[Seq[(InternalRow, Int)]] = None,
+ applyPartialClustering: Boolean = false,
+ replicatePartitions: Boolean = false) {
+ override def equals(other: Any): Boolean = other match {
+ case other: StoragePartitionJoinParams =>
+ this.commonPartitionValues == other.commonPartitionValues &&
+ this.replicatePartitions == other.replicatePartitions &&
+ this.applyPartialClustering == other.applyPartialClustering
+ case _ =>
+ false
+ }
+
+ override def hashCode(): Int = Objects.hashCode(
+ commonPartitionValues: Option[Seq[(InternalRow, Int)]],
Review Comment:
Sorry i just remembered, this is due to a scala compiler problem:
```
[error]
/Users/szehon/repos/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:263:5:
the result type of an implicit conversion must be more specific than Object
```
I think due to java method taking (Object...objects )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
