lu-wang-dl commented on code in PR #41973:
URL: https://github.com/apache/spark/pull/41973#discussion_r1264228416
##########
python/pyspark/ml/torch/distributor.py:
##########
@@ -514,11 +514,26 @@ def _execute_command(
f"Command {cmd} failed with return code {task.returncode}. "
f"The {last_n_msg} included below: {task_output}"
)
+ @staticmethod
+ def _get_output_from_framework_wrapper(framework_wrapper:
Optional[Callable], input_params: Dict, train_object: Union[Callable, str],
run_pytorch_file_fn: Optional[Callable], *args, **kwargs) -> Optional[Any]:
+ if not framework_wrapper:
+ raise RuntimeError("In the _get_output_from_framework_wrapper
function, found a framework wrapper that is none. I wonder why this is...")
Review Comment:
What does this error message mean?
##########
python/pyspark/ml/torch/distributor.py:
##########
@@ -514,11 +515,26 @@ def _execute_command(
f"Command {cmd} failed with return code {task.returncode}. "
f"The {last_n_msg} included below: {task_output}"
)
+ @staticmethod
+ def _get_output_from_framework_wrapper(framework_wrapper:
Optional[Callable], input_params: Dict, train_object: Union[Callable, str],
run_pytorch_file_fn: Optional[Callable], *args, **kwargs) -> Optional[Any]:
Review Comment:
You may add a doc string to explain what this function do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
