juliuszsompolski commented on code in PR #41443:
URL: https://github.com/apache/spark/pull/41443#discussion_r1264234727
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteThreadRunner.scala:
##########
@@ -92,7 +92,8 @@ private[connect] class ExecuteThreadRunner(executeHolder:
ExecuteHolder) extends
"execute",
executeHolder.responseObserver,
executeHolder.sessionHolder.userId,
- executeHolder.sessionHolder.sessionId)
+ executeHolder.sessionHolder.sessionId,
+ Some(executeHolder.eventsManager).filter(_ => !interrupted))
Review Comment:
this warrants at least a code comment.
this is because you don't want to post an error after canceled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
