Hisoka-X commented on PR #42005: URL: https://github.com/apache/spark/pull/42005#issuecomment-1636618410
> Hmm, instead of duplicating test time (I remember SQLQueryTestSuite takes quite long to run), maybe we should consider enable it by default? After adding this test, it will take no more than two hours. I think it needs to be tested whether the configuration is enabled or not at now. > I'm also wondering if all PartitionEvaluator-enabled operators are tested in SQLQueryTestSuite? 🤔 I'm not check this, the SQLQueryTestSuite could cover most case not all. Some operators maybe should add test too. This test is just to make sure that the overall operation is ok. This is a most faster and easier way to test most case. After do this, some common operator like `Project`, `Map` so on doesn't need add test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
