mridulm commented on code in PR #41821:
URL: https://github.com/apache/spark/pull/41821#discussion_r1264345464


##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientDistributedCacheManager.scala:
##########
@@ -117,48 +117,62 @@ private[spark] class ClientDistributedCacheManager() 
extends Logging {
    * Returns a boolean to denote whether a cache file is visible to all 
(public)
    * @return true if the path in the uri is visible to all, false otherwise
    */
-  private def isPublic(conf: Configuration, uri: URI, statCache: Map[URI, 
FileStatus]): Boolean = {
-    val fs = FileSystem.get(uri, conf)

Review Comment:
   Let us remove this change (`conf` with `fs`), it is unrelated to what we are 
trying to fix.
   The actual call itself is cheap, since it is locally cached already.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to