jchen5 commented on PR #42026: URL: https://github.com/apache/spark/pull/42026#issuecomment-1637309370
Yes, that would be good to double check. In this PR I fixed the iterators for rank and dense_rank. The row_number iterator looks fine (since it just has to increment a counter, doesn't need to do row comparisons.) Those should be the only 3 iterators supported in the InferWindowGroupLimit optimization, but do you know if there may be other iterators elsewhere with a similar problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
