zhengruifeng commented on code in PR #42026:
URL: https://github.com/apache/spark/pull/42026#discussion_r1266101093


##########
sql/core/src/test/resources/sql-tests/results/window.sql.out:
##########
@@ -1342,3 +1342,93 @@ org.apache.spark.sql.AnalysisException
     "windowName" : "w"
   }
 }
+
+
+-- !query
+create or replace temp view t1 (p, o) as values (1, 1), (1, 1), (1, 2), (2, 
1), (2, 1), (2, 2)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+select * from (select *, dense_rank() over (partition by p order by o) as rnk 
from t1) where rnk = 1
+-- !query schema
+struct<p:int,o:int,rnk:int>
+-- !query output
+1      1       1
+1      1       1
+2      1       1
+2      1       1

Review Comment:
   @beliefer I just test this against `Spark 3.3.2`:
   
   ```
   spark-sql> create or replace temp view t1 (p, o) as values (1, 1), (1, 1), 
(1, 2), (2, 1), (2, 1), (2, 2);
   Time taken: 0.955 seconds
   spark-sql> select * from (select *, dense_rank() over (partition by p order 
by o) as rnk from t1) where rnk = 1;
   1    1       1
   1    1       1
   2    1       1
   2    1       1
   Time taken: 1.101 seconds, Fetched 4 row(s)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to