grundprinzip commented on code in PR #42009:
URL: https://github.com/apache/spark/pull/42009#discussion_r1266441534


##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -616,13 +632,31 @@ message InterruptRequest {
   enum InterruptType {
     INTERRUPT_TYPE_UNSPECIFIED = 0;
 
-    // Interrupt all running executions within session with provided 
session_id.
+    // Interrupt all running executions within the session with the provided 
session_id.
     INTERRUPT_TYPE_ALL = 1;
+
+    // Interrupt all running executions within the session with the provided 
operation_tag.
+    INTERRUPT_TYPE_TAG = 2;
+
+    // Interrupt the running execution within the session with the provided 
operation_id.
+    INTERRUPT_TYPE_ID = 3;

Review Comment:
   INTERRUPT_TYPE_OP_ID?



##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala:
##########
@@ -86,4 +94,24 @@ private[connect] class ExecuteHolder(
   def interrupt(): Unit = {
     runner.interrupt()
   }
+
+  def tagToSparkJobTag(tag: String): String = {

Review Comment:
   Doc on what this is used for?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to