WweiL commented on code in PR #42096:
URL: https://github.com/apache/spark/pull/42096#discussion_r1269895037
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/StreamingForeachBatchHelper.scala:
##########
@@ -44,16 +44,16 @@ object StreamingForeachBatchHelper extends Logging {
sessionHolder: SessionHolder): ForeachBatchFnType = { (df: DataFrame,
batchId: Long) =>
{
val dfId = UUID.randomUUID().toString
- log.info(s"Caching DataFrame with id $dfId") // TODO: Add query id to
the log.
+ logInfo(s"Caching DataFrame with id $dfId") // TODO: Add query id to the
log.
- // TODO: Sanity check there is no other active DataFrame for this query.
The query id
- // needs to be saved in the cache for this check.
+ // TODO(SPARK-44462): Sanity check there is no other active DataFrame
for this query.
Review Comment:
Added spark tickets to each TODO to make sure we don't forget. It could be
that the ticket and the comment content doesn't match. cc @rangadi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
