Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/6310#discussion_r30936909
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -43,15 +43,25 @@ private[spark] case class Heartbeat(
*/
private[spark] case object TaskSchedulerIsSet
-private[spark] case object ExpireDeadHosts
-
+private[spark] case object ExpireDeadHosts
+
+private case class ExecutorRegistered(executorId: String)
+
+private case class ExecutorRemoved(executorId: String)
+
private[spark] case class HeartbeatResponse(reregisterBlockManager:
Boolean)
/**
* Lives in the driver to receive heartbeats from executors..
*/
-private[spark] class HeartbeatReceiver(sc: SparkContext)
- extends ThreadSafeRpcEndpoint with Logging {
+private[spark] class HeartbeatReceiver(sc: SparkContext, clock: Clock)
+ extends ThreadSafeRpcEndpoint with SparkListener with Logging {
+
+ def this(sc: SparkContext) {
+ this(sc, new SystemClock)
--- End diff --
Could you make `SystemClock` as a default value to save one constructor,
please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
