galacticgumshoe opened a new pull request, #52:
URL: https://github.com/apache/spark-docker/pull/52

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
   -->
   
   ### What changes were proposed in this pull request? 
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If there is design documentation, please add the link.
     2. If there is a discussion in the mailing list, please add the link.
   -->
   Add a Scala 2.13 Dockerfile to the Spark 3.4.1 sub-folder for building and 
tagging `3.4.1-scala2.13-java11-ubuntu`, `3.4.1-scala2.13`, `scala2.13` image.
   
   ### Why are the changes needed? 
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you fix a bug, you can clarify why it is a bug.
   -->
   To provide support for projects using Scala 2.13 and Spark 3.4.1.
   
   ### Does this PR introduce _any_ user-facing change? 
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   Yes, this would add new Docker tags: `3.4.1-scala2.13-java11-ubuntu`, 
`3.4.1-scala2.13`, `scala2.13`.
   
   ### How was this patch tested? 
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   1. Ran `./add-dockerfiles.sh 3.4.1` in my local
   2. Once I verified the appropriate directory, Dockerfile, and entrypoint.sh 
were generated in `3.4.1/scala2.13-java11-ubuntu` I then built an image in my 
local: `docker build --platform linux/amd64 -t <image>:<tag> 
3.4.1/scala2.13-java11-ubuntu/`
   3. Verified the correct binary was downloaded in the 2.13 image: 
https://archive.apache.org/dist/spark/spark-3.4.1/spark-3.4.1-bin-hadoop3-scala2.13.tgz.
   4. Ran spark-shell and verified versions (2.13): `docker run -it 
<image>:<tag> /opt/spark/bin/spark-shell`
   > Welcome to
         ____              __
        / __/__  ___ _____/ /__
       _\ \/ _ \/ _ `/ __/  '_/
      /___/ .__/\_,_/_/ /_/\_\   version 3.4.1
         /_/
   Using Scala version 2.13.8 (OpenJDK 64-Bit Server VM, Java 11.0.19)
   5. I also built the scala2.12 image in my local: `docker build --platform 
linux/amd64 -t <image>:<tag> 3.4.1/scala2.12-java11-ubuntu/`.
   7. Verified the correct binary was downloaded in the 2.12 image: 
https://archive.apache.org/dist/spark/spark-3.4.1/spark-3.4.1-bin-hadoop3.tgz
   8. Ran spark-shell and verified versions (2.12): `docker run -it 
<image>:<tag> /opt/spark/bin/spark-shell`
   >Welcome to
         ____              __
        / __/__  ___ _____/ /__
       _\ \/ _ \/ _ `/ __/  '_/
      /___/ .__/\_,_/_/ /_/\_\   version 3.4.1
         /_/
   Using Scala version 2.12.17 (OpenJDK 64-Bit Server VM, Java 11.0.19)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to