zhengruifeng commented on code in PR #42167:
URL: https://github.com/apache/spark/pull/42167#discussion_r1277017168
##########
.github/workflows/build_and_test.yml:
##########
@@ -629,7 +629,22 @@ jobs:
- name: Spark connect jvm client mima check
if: inputs.branch != 'branch-3.3'
run: ./dev/connect-jvm-client-mima-check
+ - name: Install Python linter dependencies for branch-3.3
+ if: inputs.branch == 'branch-3.3'
+ run: |
+ # SPARK-44554: Copy from
https://github.com/apache/spark/blob/073d0b60d31bf68ebacdc005f59b928a5902670f/.github/workflows/build_and_test.yml#L501-L508
+ # Should delete this section after SPARK 3.3 EOL.
+ python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme
'mypy==0.920' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc
'jinja2<3.0.0' 'black==21.12b0'
+ python3.9 -m pip install 'pandas-stubs==1.2.0.53'
+ - name: Install Python linter dependencies for branch-3.4
+ if: inputs.branch == 'branch-3.4'
+ run: |
+ # SPARK-44554: Copy from
https://github.com/apache/spark/blob/a05c27e85829fe742c1828507a1fd180cdc84b54/.github/workflows/build_and_test.yml#L571-L578
+ # Should delete this section after SPARK 3.4 EOL.
+ python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme
'mypy==0.920' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc
'jinja2<3.0.0' 'black==22.6.0'
+ python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython
'grpcio==1.48.1' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0'
- name: Install Python linter dependencies
+ if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4'
Review Comment:
I'm not sure about this, maybe we need dedicated workflows for 3.3/3.4/3.5,
instead of reusing the master one
let's wait for more feedbacks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
