hvanhovell commented on code in PR #42069:
URL: https://github.com/apache/spark/pull/42069#discussion_r1278219437
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/artifact/SparkConnectArtifactManager.scala:
##########
@@ -161,7 +162,19 @@ class SparkConnectArtifactManager(sessionHolder:
SessionHolder) extends Logging
*/
def classloader: ClassLoader = {
val urls = getSparkConnectAddedJars :+ classDir.toUri.toURL
- new URLClassLoader(urls.toArray, Utils.getContextOrSparkClassLoader)
+ val loader = if
(SparkEnv.get.conf.get(CONNECT_SCALA_UDF_STUB_CLASSES).nonEmpty) {
+ val stubClassLoader =
+ StubClassLoader(null,
SparkEnv.get.conf.get(CONNECT_SCALA_UDF_STUB_CLASSES))
+ new ChildFirstURLClassLoader(
Review Comment:
Should this follow the same rules for classpath resolution we have on the
executor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
