rangadi commented on code in PR #42193:
URL: https://github.com/apache/spark/pull/42193#discussion_r1278630837
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectStreamingQueryCacheSuite.scala:
##########
@@ -95,7 +95,9 @@ class SparkConnectStreamingQueryCacheSuite extends
SparkFunSuite with MockitoSug
// Query is returned when correct session is used
assert(sessionMgr.getCachedQuery(queryId, runId,
mockSession).contains(mockQuery))
- // Stop the query.
+ // Cleanup the query and verify if stop() method has been called.
+ sessionMgr.cleanupRunningQueries(sessionHolder)
Review Comment:
This is not testing the desired functionality. It is just testing this
cleanup method, not how it is used. we want the session to timeout normally and
associated queries should be closed.
Can we add a test for that? Also, we should manually verify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
