ulysses-you commented on code in PR #42199:
URL: https://github.com/apache/spark/pull/42199#discussion_r1278688677


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1375,6 +1375,12 @@ object SQLConf {
     .timeConf(TimeUnit.SECONDS)
     .createWithDefaultString(s"${5 * 60}")
 
+  val INTERRUPT_ON_CANCEL = buildConf("spark.sql.execution.interruptOnCancel")
+    .doc("When true, all running tasks will be interrupted if one cancels a 
query.")
+    .version("3.5.0")

Review Comment:
   I'm fine to add this to 3.5.0 if it does not block some thing. Since 3.5.0 
we change the default interruptOnCancel to true in thrift mode and we have new 
interruptOnCancel api at spark context and connect. I think it's a chance to 
also have same behavior at sql execution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to