eejbyfeldt commented on PR #41876: URL: https://github.com/apache/spark/pull/41876#issuecomment-1658490236
Reverted the test case. > @eejbyfeldt I did not consider it. I just implemented the existing spec. Value classes are a bit special. I can take a look, but I am not sure if I have time before the first 3.5 RC. Yeah, they are annoying and that they are not explicitly represented inside the `AgnosticEncoder` (we "throw" information about there existence when creating the encoder) makes them harder to handle correctly. The code in this PR would be probably be cleaner/more explicit if one could ask the encoder directly if it is a value class. But I did not take the route in the PR to make the changes smaller and more local. But maybe it actually worth while taking that route if it makes it easier to handle the value classes in more cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
