juliuszsompolski commented on code in PR #42235:
URL: https://github.com/apache/spark/pull/42235#discussion_r1281168403
##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -606,26 +622,35 @@ def __init__(
"initial_backoff": 50,
"max_backoff": 60000,
}
- if retryPolicy:
- self._retry_policy.update(retryPolicy)
+ if retry_policy:
+ self._retry_policy.update(retry_policy)
# Generate a unique session ID for this client. This UUID must be
unique to allow
# concurrent Spark sessions of the same user. If the channel is
closed, creating
# a new client will create a new session ID.
self._session_id = str(uuid.uuid4())
if self._builder.userId is not None:
self._user_id = self._builder.userId
- elif userId is not None:
- self._user_id = userId
+ elif user_id is not None:
+ self._user_id = user_id
else:
self._user_id = os.getenv("USER", None)
self._channel = self._builder.toChannel()
self._closed = False
self._stub = grpc_lib.SparkConnectServiceStub(self._channel)
self._artifact_manager = ArtifactManager(self._user_id,
self._session_id, self._channel)
+ self._use_reattachable_execute = use_reattachable_execute
# Configure logging for the SparkConnect client.
+ def disable_reattachable_execute(self) -> "SparkConnectClient":
Review Comment:
This is used only when creating ExecutePlanResponseReattachableIterator, and
once that's created, it will know what to do even if this gets flipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
