itholic commented on code in PR #42270:
URL: https://github.com/apache/spark/pull/42270#discussion_r1281262055
##########
python/pyspark/pandas/base.py:
##########
@@ -1625,11 +1625,10 @@ def factorize(
Parameters
----------
sort : bool, default True
Review Comment:
> If True, the encoding will be sorted, otherwise the order of encoding
depends on the order of appearance of the values.
Yes, but seems like we currently don't support `False` for `sort` for now in
pandas API on Spark for some reason. @xinrong-meng do you remember why we only
support only `True` for `sort` parameter?? (as an original author for this
functions from [old PR](https://github.com/databricks/koalas/pull/1972) 😂 )
##########
python/pyspark/pandas/base.py:
##########
@@ -1625,11 +1625,10 @@ def factorize(
Parameters
----------
sort : bool, default True
Review Comment:
> If True, the encoding will be sorted, otherwise the order of encoding
depends on the order of appearance of the values.
Yes, but seems like we currently don't support `False` for `sort` for now in
pandas API on Spark for some reason. @xinrong-meng do you remember why we only
support only `True` for `sort` parameter?? (as an original author for this
functions from [old PR](https://github.com/databricks/koalas/pull/1972) 😂 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
