cloud-fan commented on code in PR #41088:
URL: https://github.com/apache/spark/pull/41088#discussion_r1281629444
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala:
##########
@@ -171,13 +172,12 @@ object FileSourceStrategy extends Strategy with
PredicateHelper with Logging {
val partitionKeyFilters =
DataSourceStrategy.getPushedDownFilters(partitionColumns,
normalizedFilters)
- // subquery expressions are filtered out because they can't be used to
prune buckets or pushed
- // down as data filters, yet they would be executed
- val normalizedFiltersWithoutSubqueries =
- normalizedFilters.filterNot(SubqueryExpression.hasSubquery)
-
val bucketSpec: Option[BucketSpec] = fsRelation.bucketSpec
val bucketSet = if (shouldPruneBuckets(bucketSpec)) {
+ // subquery expressions are filtered out because they can't be used to
prune buckets
Review Comment:
seems it's fine to not filter out scalar subquery, as the code of
`genBucketSet` can skip it already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
