agubichev commented on code in PR #41301:
URL: https://github.com/apache/spark/pull/41301#discussion_r1282510234
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala:
##########
@@ -826,8 +882,13 @@ object DecorrelateInnerQuery extends PredicateHelper {
} else {
(right, Nil, AttributeMap.empty[Attribute])
}
- val newOuterReferenceMap = leftOuterReferenceMap ++
rightOuterReferenceMap
- val newJoinCond = leftJoinCond ++ rightJoinCond
+ val newOuterReferenceMap = leftOuterReferenceMap ++
rightOuterReferenceMap ++
+ equivalences
+ val newCorrelated =
+ if (shouldDecorrelatePredicates) {
+ replaceOuterReferences(predicates, newOuterReferenceMap)
Review Comment:
done, added a test as well.
we can just keep all the join's predicates for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
