dongjoon-hyun commented on PR #42323: URL: https://github.com/apache/spark/pull/42323#issuecomment-1664659058
Thank you for review, @viirya . Yes, right. > [SPARK-43043](https://issues.apache.org/jira/browse/SPARK-43043) was only reverted from branch-3.4 but not from 3.5 and master, right? Do you mean here? There is no null check there. > I saw there is null check in getMapOutputLocation, but this looks safer. https://github.com/apache/spark/blob/f824d058b14e3c58b1c90f64fefc45fac105c7dd/core/src/main/scala/org/apache/spark/MapOutputTracker.scala#L1154C2-L1158 Without this patch, `getMapOutputLocation` throws NPE. Here is the test case. - https://github.com/apache/spark/pull/42326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
