peter-toth commented on PR #42223: URL: https://github.com/apache/spark/pull/42223#issuecomment-1665623401
> @peter-toth Setting aside the previous discussion, after all, the current implementation is the simplest pattern, which is also an advantage that cannot be ignored. If adding a project can bring performance improvement, we can follow up and improve. If we want to push this PR for some reason I'm not against it if the above mentioned correctness issue gets fixed (https://github.com/apache/spark/pull/42223#discussion_r1279051263). But honestly, I don't like the idea that we duplicate the code of `MergeScalarSubqueries.tryMergePlans()` with some modifications into this new rule just because we don't want to fix agregate merging there. IMO if we all on the same page about the discussed solution in https://github.com/apache/spark/pull/42223#issuecomment-1665208447 then we should update `MergeScalarSubqueries.tryMergePlans()` (in https://github.com/apache/spark/pull/37630) and use the updated common merging logic in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
