juliuszsompolski opened a new pull request, #42355: URL: https://github.com/apache/spark/pull/42355
### What changes were proposed in this pull request? WIP If handling is done directly on the GRPC thread, flow control OnReady events are getting queued until after the handler returns, so OnReadyHandler never gets notified until after the handler exits... When handler just sets everything up, and launches a thread to handle ExecuteGrpcResponseSender.run, the handler is finished, and further events can arrive. ### Why are the changes needed? WIP ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Before: ``` 23/08/05 00:41:41 ERROR ExecuteGrpcResponseSender: Wait for grpcCallObserver to become ready with timeout=17317 ms. org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.$anonfun$sendResponse$2(ExecuteGrpcResponseSender.scala:238) org.apache.spark.internal.Logging.logError(Logging.scala:76) org.apache.spark.internal.Logging.logError$(Logging.scala:75) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.logError(ExecuteGrpcResponseSender.scala:38) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.sendResponse(ExecuteGrpcResponseSender.scala:237) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.run(ExecuteGrpcResponseSender.scala:173) org.apache.spark.sql.connect.service.ExecuteHolder.attachAndRunGrpcResponseSender(ExecuteHolder.scala:121) org.apache.spark.sql.connect.service.SparkConnectExecutePlanHandler.handle(SparkConnectExecutePlanHandler.scala:39) org.apache.spark.sql.connect.service.SparkConnectService.executePlan(SparkConnectService.scala:73) org.apache.spark.connect.proto.SparkConnectServiceGrpc$MethodHandlers.invoke(SparkConnectServiceGrpc.java:743) org.sparkproject.connect.grpc.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182) org.sparkproject.connect.grpc.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:346) org.sparkproject.connect.grpc.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:860) org.sparkproject.connect.grpc.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) org.sparkproject.connect.grpc.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) ... 23/08/05 00:41:58 ERROR ExecuteGrpcResponseSender: Deadline reached, finishing stream after index 3. 23/08/05 00:41:58 ERROR ExecuteGrpcResponseSender: ON READY org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.$anonfun$run$2(ExecuteGrpcResponseSender.scala:90) org.sparkproject.connect.grpc.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onReady(ServerCalls.java:206) org.sparkproject.connect.grpc.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:188) org.sparkproject.connect.grpc.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:346) org.sparkproject.connect.grpc.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:860) org.sparkproject.connect.grpc.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) org.sparkproject.connect.grpc.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) ``` After: ``` 23/08/05 01:05:14 ERROR ExecuteGrpcResponseSender: Sent response index=1007. 23/08/05 01:05:14 ERROR ExecuteGrpcResponseSender: Wait for grpcCallObserver to become ready with timeout=16988 ms. org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.$anonfun$sendResponse$2(ExecuteGrpcResponseSender.scala:258) org.apache.spark.internal.Logging.logError(Logging.scala:76) org.apache.spark.internal.Logging.logError$(Logging.scala:75) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.logError(ExecuteGrpcResponseSender.scala:38) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.sendResponse(ExecuteGrpcResponseSender.scala:257) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.execute(ExecuteGrpcResponseSender.scala:193) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender$$anon$1.run(ExecuteGrpcResponseSender.scala:83) 23/08/05 01:05:14 ERROR ExecuteGrpcResponseSender: ON READY org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.$anonfun$run$1(ExecuteGrpcResponseSender.scala:71) org.sparkproject.connect.grpc.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onReady(ServerCalls.java:206) org.sparkproject.connect.grpc.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.onReady(ServerCallImpl.java:385) org.sparkproject.connect.grpc.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1OnReady.runInContext(ServerImpl.java:933) org.sparkproject.connect.grpc.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) org.sparkproject.connect.grpc.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) 23/08/05 01:05:14 ERROR ExecuteGrpcResponseSender: Sent response index=1008. 23/08/05 01:05:14 ERROR ExecuteGrpcResponseSender: Wait for grpcCallObserver to become ready with timeout=16988 ms. org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.$anonfun$sendResponse$2(ExecuteGrpcResponseSender.scala:258) org.apache.spark.internal.Logging.logError(Logging.scala:76) org.apache.spark.internal.Logging.logError$(Logging.scala:75) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.logError(ExecuteGrpcResponseSender.scala:38) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.sendResponse(ExecuteGrpcResponseSender.scala:257) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.execute(ExecuteGrpcResponseSender.scala:193) org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender$$anon$1.run(ExecuteGrpcResponseSender.scala:83) 23/08/05 01:05:14 ERROR ExecuteGrpcResponseSender: ON READY org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender.$anonfun$run$1(ExecuteGrpcResponseSender.scala:71) org.sparkproject.connect.grpc.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onReady(ServerCalls.java:206) org.sparkproject.connect.grpc.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.onReady(ServerCallImpl.java:385) org.sparkproject.connect.grpc.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1OnReady.runInContext(ServerImpl.java:933) org.sparkproject.connect.grpc.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) org.sparkproject.connect.grpc.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) 23/08/05 01:05:14 ERROR ExecuteGrpcResponseSender: Sent response index=1009. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
