LuciferYang commented on code in PR #41746:
URL: https://github.com/apache/spark/pull/41746#discussion_r1285080603
##########
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala:
##########
@@ -49,6 +50,10 @@ private[spark] object CoarseGrainedClusterMessages {
case class KillExecutorsOnHost(host: String)
extends CoarseGrainedClusterMessage
+ case class UpdateExecutorsLogLevel(logLevel: String) extends
CoarseGrainedClusterMessage
Review Comment:
If we need the mima check pass for both Scala 2.12 and Scala 2.13,
`SparkAppConfig` might need to be designed as follows:
```scala
case class SparkAppConfig(
sparkProperties: Seq[(String, String)],
ioEncryptionKey: Option[Array[Byte]],
hadoopDelegationCreds: Option[Array[Byte]],
resourceProfile: ResourceProfile)
extends CoarseGrainedClusterMessage {
private var _logLevel: Option[String] = None
def logLevel: Option[String] = _logLevel
def this(
sparkProperties: Seq[(String, String)],
ioEncryptionKey: Option[Array[Byte]],
hadoopDelegationCreds: Option[Array[Byte]],
resourceProfile: ResourceProfile,
logLevel: Option[String]) = {
this(sparkProperties, ioEncryptionKey, hadoopDelegationCreds,
resourceProfile)
this._logLevel = logLevel
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
