itholic commented on code in PR #40665:
URL: https://github.com/apache/spark/pull/40665#discussion_r1285356583
##########
python/pyspark/pandas/namespace.py:
##########
@@ -1875,36 +1872,31 @@ def date_range(
'2019-01-31'],
dtype='datetime64[ns]', freq=None)
- `closed` controls whether to include `start` and `end` that are on the
+ `inclusive` controls whether to include `start` and `end` that are on the
boundary. The default includes boundary points on either end.
Review Comment:
nit: to match the pandas docs
```suggestion
`inclusive` controls whether to include `start` and `end` that are on the
boundary. The default, “both”, includes boundary points on either end.
```
##########
python/pyspark/pandas/namespace.py:
##########
@@ -1875,36 +1872,31 @@ def date_range(
'2019-01-31'],
dtype='datetime64[ns]', freq=None)
- `closed` controls whether to include `start` and `end` that are on the
+ `inclusive` controls whether to include `start` and `end` that are on the
boundary. The default includes boundary points on either end.
Review Comment:
nit: to match the pandas docs
```suggestion
`inclusive` controls whether to include `start` and `end` that are on the
boundary. The default, “both”, includes boundary points on either end.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
