advancedxy commented on code in PR #42255:
URL: https://github.com/apache/spark/pull/42255#discussion_r1285990200
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1407,7 +1407,15 @@ class Dataset[T] private[sql](
*/
@scala.annotation.varargs
def hint(name: String, parameters: Any*): Dataset[T] = withTypedPlan {
Review Comment:
> Treating String as SQL string is too tricky. We may break things and there
is no way to specify string literals as hint parameters.
For the built-in hints(join hints, repartition/rebalance hints), I believe
it's safe to treat String as SQL String(`UnresolvedAttribute`).
> Can we accept Column input?
We have to refactor the `ResolveHints` rule then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
