liangyu-1 opened a new pull request, #42405:
URL: https://github.com/apache/spark/pull/42405
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
I make the SecurityManager instance a lazy value
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix the bug in issue
[SPARK-44581](https://issues.apache.org/jira/browse/SPARK-44581)
**Bug:**
In spark3.2 it throws the org.apache.hadoop.security.AccessControlException,
but in spark2.4 this hook does not throw exception.
I rebuild the hadoop-client-api.jar, and add some debug log before the
hadoop shutdown hook is created, and rebuild the spark-yarn.jar to add some
debug log when creating the spark shutdown hook manager, here is the screenshot
of the log:
We can see from the screenshot, the ShutdownHookManager is initialized
before the ApplicationManager create a new ugi.
**Reason**
The main cause is that ShutdownHook thread is created before we create the
ugi in ApplicationMaster.
When we set the config key "hadoop.security.credential.provider.path", the
ApplicationMaster will try to get a filesystem when generating SSLOptions, and
when initialize the filesystem during which it will generate a new thread whose
ugi is inherited from the current process (yarn).
After this, it will generate a new ugi (SPARK_USER) in ApplicationMaster and
execute the doAs() function.
Here is the chain of the call:
ApplicationMaster.(ApplicationMaster.scala:83) ->
org.apache.spark.SecurityManager.(SecurityManager.scala:98) ->
org.apache.spark.SSLOptions$.parse(SSLOptions.scala:188) ->
org.apache.hadoop.conf.Configuration.getPassword(Configuration.java:2353) ->
org.apache.hadoop.conf.Configuration.getPasswordFromCredentialProviders(Configuration.java:2434)
->
org.apache.hadoop.security.alias.CredentialProviderFactory.getProviders(CredentialProviderFactory.java:82)
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
I didn't add new UnitTest for this, but I rebuild the package, and runs a
program in my cluster, and turns out that the user when I delete the staging
file turns to be the same with the SPARK_USER.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
